Skip to content

[None][infra] Prune stale entries from legacy-files.txt - #22019

Open
Ethereal49 wants to merge 1 commit into
NVIDIA:mainfrom
Ethereal49:chore/prune-legacy-files-21383
Open

[None][infra] Prune stale entries from legacy-files.txt#22019
Ethereal49 wants to merge 1 commit into
NVIDIA:mainfrom
Ethereal49:chore/prune-legacy-files-21383

Conversation

@Ethereal49

@Ethereal49 Ethereal49 commented Nov 10, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown

Description

legacy-files.txt listed 11 Python paths absent from the Git tree at NVIDIA/TensorRT-LLM:main (70fe2b2a). Ran python3 scripts/legacy_utils.py prune-files and python3 scripts/legacy_utils.py gen-configs. The diff deletes only those paths and their references in ruff-legacy.toml, pyproject.toml, and .pre-commit-config.yaml; the 707 valid entries retain their original order. The separate violation snapshot is unchanged.

Removed paths (11) 
tensorrt_llm/_torch/pyexecutor/finish_reason.py
tensorrt_llm/_torch/pyexecutor/kv_cache/mamba_cache_manager.py
tensorrt_llm/bench/dataclasses/engine.py
tests/integration/defs/accuracy/test_cli_flow.py
tests/integration/defs/accuracy/test_llm_api_pytorch_ray.py
tests/integration/defs/examples/test_phi.py
tests/unittest/_torch/modeling/test_modeling_qwen.py
tests/unittest/_torch/modeling/test_modeling_qwen2_5vl.py
tests/unittest/_torch/modeling/test_modeling_qwen_moe.py
tests/unittest/_torch/modeling/test_modeling_vila.py
tests/unittest/llmapi/apps/_test_openai_multi_nodes.py

Fixes #21383

Implemented with Codex (AI-assisted)

Test Coverage

  • python3 scripts/legacy_utils.py check-configs — passed.
  • pytest -q -c "$CPU_PYTEST_INI" --rootdir "$PWD" --noconftest -m cpu_only tests/unittest/scripts/test_legacy_utils.py — 46 passed. The temporary pytest config registers cpu_only; the default invocation stops during collection on this host because the repository-wide conftest imports the TensorRT-LLM build.
  • Applicable pre-commit and DCO hooks passed.
  • GPU and model tests were not run.

PR Checklist

  • Please check this after reviewing the above items as appropriate for this PR.

Dev Engineer Review

The PR removes 11 stale paths from legacy-files.txt and the corresponding entries from the Ruff and pre-commit configurations. The changes keep the remaining entries in order and do not modify source code or test files. No behavior regression is evident from this diff.

QA Engineer Review

No test changes.

Per-File QA Perspective

  • .pre-commit-config.yaml: Removes absent paths from the common-files and legacy-files hook match lists. This changes which files those hooks select; it does not change hook definitions.
  • legacy-files.txt: Removes 11 paths that are no longer present. This changes the legacy file inventory only.
  • pyproject.toml: Removes the same stale paths from Ruff’s formatting exclusion list. No formatting behavior for existing files changes.
  • ruff-legacy.toml: Removes the stale paths from Ruff’s legacy include list. No test code or test-list files changed.

@Ethereal49
chore: prune 11 stale legacy lint paths
ec6c073 
Signed-off-by: ethereal49 <hongyeluo49@gmail.com>
@Ethereal49
Ethereal49 requested review from a team as code owners November 10, 2026 15:37
@coderabbitai

coderabbitai Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The changes update source and test path membership in the legacy inventory, pre-commit lists, Ruff formatting exclusions, and the legacy Ruff include list.

Changes

File inventory and lint scope

Layer / File(s) Summary
Synchronize file inventories
.pre-commit-config.yaml, legacy-files.txt, pyproject.toml, ruff-legacy.toml		 The lists add selected PyExecutor and test paths and remove other source, benchmark, integration-test, modeling-test, and multi-node test paths. Ruff formatting exclusions and legacy Ruff includes reflect the updated path selections.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related PRs

  • NVIDIA/TensorRT-LLM#20669: Renames PyExecutor tests and updates lint and legacy-list paths that overlap with the path inventory changes here.

Suggested labels: Agent Code Review: Low Risk

Suggested reviewers: chzblych, brnguyen2

Merge Risk: Minimal · up to ec6c0

This change removes stale file paths from the legacy lint and format inventories and their derived configs. It does not alter runtime behavior. No concrete merge risk was found.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title follows the repository’s title format and clearly identifies the removal of stale entries from legacy-files.txt.
Description check Passed The description explains the change, lists the removed paths, reports relevant test coverage, and completes the PR checklist.
Linked Issues check Passed Issue #21383 asks to remove 11 stale paths from legacy-files.txt and regenerate the configs. The diff removes the 11 listed paths from legacy-files.txt, .pre-commit-config.yaml, pyproject.toml…
Out of Scope Changes check Passed The diff changes only the stale-path inventory and matching generated hook and Ruff configuration entries. These changes directly support issue #21383. No unrelated changes appear in the diff.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Full details: Linked Issues check

Explanation

Issue #21383 asks to remove 11 stale paths from legacy-files.txt and regenerate the configs. The diff removes the 11 listed paths from legacy-files.txt, .pre-commit-config.yaml, pyproject.toml, and ruff-legacy.toml. The PR description reports running prune-files, gen-configs, and check-configs.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 70fe2b2 and ec6c073.

Files selected for processing: 4

  • .pre-commit-config.yaml
  • legacy-files.txt
  • pyproject.toml
  • ruff-legacy.toml
Files with no reviewable changes: 4

  • .pre-commit-config.yaml
  • pyproject.toml
  • ruff-legacy.toml
  • legacy-files.txt

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZhanruiSunCh ZhanruiSunCh Awaiting requested review from ZhanruiSunCh ZhanruiSunCh is a code owner automatically assigned from NVIDIA/trt-llm-infra-devs
@tburt-nv tburt-nv Awaiting requested review from tburt-nv tburt-nv is a code owner automatically assigned from NVIDIA/trt-llm-infra-devs
@schetlur-nv schetlur-nv Awaiting requested review from schetlur-nv schetlur-nv is a code owner automatically assigned from NVIDIA/trt-llm-devs
@brnguyen2 brnguyen2 Awaiting requested review from brnguyen2 brnguyen2 is a code owner automatically assigned from NVIDIA/trt-llm-devs

At least 1 approving review is required to merge this pull request.

Assignees

@Ethereal49 Ethereal49

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: Remove stale entries from legacy-files.txt

1 participant

@Ethereal49